[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: restructure patch for review [bug-grep]

From: Claudio Fontana
Subject: Re: restructure patch for review [bug-grep]
Date: Tue, 8 Mar 2005 01:14:37 +0100 (CET)

> If a -p option similar to that of diff is ever
> implemented (actually, I've had mine running for
> weeks now, but based off an older RH version),
> two struct variables would eventually need to be
> constructed stlighly differently.
> Plus, there
> are place in src/grep.c where some of their
> fields might be directly accessed.

Aside from little details I think we got the picture
sufficiently clear, we'll eventually discuss interface
further at a later stage when your search_spec has
taken form.

In the meantime, I'll keep the restructure based on
current search.c; when your interface is ready I'll
change it to meet your new version for an eventual
2.6.0 startup.

Stepan, what's your opinion on this versioning issue?
What's your opinion on the restructure patch as a
whole? I tried to start implementing your design as
requested, tell me if I am coming close to what you

> > > Maybe I should also rename "match_spec" to
> > > "search_spec" to correspond to the file name
> > > before even publishing a first version.
> > 
> > Seems nicer.
> Yes, but both abbreviated forms leave to be
> desired for different reasons:  ss and ms.
> Nan, too much attention to details!

:) countrary to ms, ss are not harmful anymore, so why
not ss? 

struct grep_state gs;
struct search_spec ss;

> They are under
>   <http://cvs.fedora.redhat.com/viewcvs/devel/grep/>
> as you already pointed to them in another message.

lol only cared about grep-2.5.1-oi.patch :P
They are not too many but maybe it would be nice for
newcomers (like me) to have the entry in savannah.

> I guess that
>   grep-2.5.1-egf-speedup.patch
> is of particular interest.

I will read it.

I think further discussion about the restructure patch
should happen here:


Sorry about bringing it up initially in the wrong
place .

Nuovo Yahoo! Messenger: E' molto più divertente: Audibles, Avatar, Webcam, 
Giochi, Rubrica… Scaricalo ora! 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]