[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug-grep] [patch #3832] fix savedir issue for gnulib import

From: Paul Eggert
Subject: [bug-grep] [patch #3832] fix savedir issue for gnulib import
Date: Mon, 21 Mar 2005 06:37:41 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041217

Follow-up Comment #3, patch #3832 (project grep):

You were better off omitting the size parameter, and staying
compatible with gnulib.  That is because POSIX says that the value
of st_size is undefined for directories, and we've encountered
hosts where st_size is effectively garbage.  If you try to invoke
malloc with a garbage argument, you're likely to allocate wayyyy
too much storage and break your program one way or another.

So I would stick with the gnulib approach here.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]