[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Applying outstanding patches [bug-grep]

From: Tim Waugh
Subject: Re: Applying outstanding patches [bug-grep]
Date: Thu, 14 Apr 2005 17:38:21 +0100
User-agent: Mutt/

On Thu, Apr 14, 2005 at 05:05:42PM +0200, Claudio Fontana wrote:

> is repeated in the patch three times.
> This cries for a helper function
> (convert_multibyte_offset ?).

While factoring out segments like this, it is really important to make
sure that they are entirely the same.  I seem to remember that some of
them are tweaked in various small ways.  The patch I currently have
(the one we're talking about) has been well tested, and I don't
believe it introduces any regressions.

Feel free to restructure it, but do please make sure to test it very

I think "more harm than good" is a little melodramatic, don't you? :-)


Attachment: pgpyTGHtD8gFJ.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]