[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug-grep] Re: [patch #3801] Red Hat's "color" patch

From: Julian Foad
Subject: [bug-grep] Re: [patch #3801] Red Hat's "color" patch
Date: Thu, 28 Apr 2005 14:29:28 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b) Gecko/20050217

Charles Levert wrote:
Follow-up Comment #2, patch #3801 (project grep):

This patch #3801 is completely obsoleted by patch #3644.  The shortcoming of
this approach are also discussed under bug #11022, which includes its own
attached patch which can also be considered obsolete and should not be
applied to CVS.

I'm glad you have a better fix, and I hope I'll get a chance to read it some time. (I'll be away for a week.) Please could you separate it from the new features introduced by patch #3644 and provide just a bug fix? If you do that, you can then mark this patch #3801 as closed, with a reference to the superior patch.

I can't accept new features until we have squashed most of the bugs, however tempting it may be to add obviously useful features in parts of the code that are being changed anyway. So, let's get some of these bugs fixed!

I see you have commit access rights now. When you have something that you want to commit, please post it here on the mailing list to give the rest of us a chance to review it and approve it, and then you can commit it.


- Julian

reply via email to

[Prev in Thread] Current Thread [Next in Thread]