[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
memory leaks in lib/savedir.h
From: |
Bert Wesarg |
Subject: |
memory leaks in lib/savedir.h |
Date: |
Wed, 01 Aug 2007 21:05:12 +0200 (CEST) |
User-agent: |
SquirrelMail/1.4.9a |
Hello all,
I found in lib/savedir.h multiple (2) memory leaks for two variables and
some more bugs. But fix is nontrivial and more that 15 lines and the FSF
has no copyright assignment from me. So I let you only know about my
findings, may be I have the time to sign the copyright assignment in the
future but not now:
* path and pathlen are not static
* pathlen is used uninitialized
* path is repeatedly overwritten by the calloc() call
* the 'slash = (path[dirlen] != '/')' line is totaly useless, because dirlen
points always to the '\0' of the previously strcpy(), so slash is always 1
* if the relloc() of name_space failed, name_space is still a valid pointer
Regards
Bert Wesarg
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- memory leaks in lib/savedir.h,
Bert Wesarg <=