|
From: | Reuben Thomas |
Subject: | Re: I volunteer to work on a couple of items |
Date: | Wed, 22 Aug 2007 22:26:48 +0100 (BST) |
On Wed, 1 Aug 2007, Reuben Thomas wrote:
On Thu, 19 Jul 2007, Tony Abou-Assaleh wrote:I would keep the options to long options only for now, rather than use an arbitrary unused letter.Fine.The copyright assignment is a must before any patch can be accepted that is longer than 10 or 15 lines, I forgot the exact number.It's now been received. I'll look over the patch again and update it in the tracker.
I have now updated the patch with only a long option. There's one comment in grep.c that is currently confusing in this area: grep.c:283:/* Non-boolean long options that have no corresponding short equivalents. */
but the list that follows already includes boolean options like LINE_BUFFERED_OPTION, and of course I've just added another. Perhaps this comment should have "Non-boolean" removed?
-- http://rrt.sc3d.org/ | compulsion, n. the eloquence of power (Bierce)
[Prev in Thread] | Current Thread | [Next in Thread] |