[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: grep-2.5.4 Test Release

From: Tony Abou-Assaleh
Subject: Re: grep-2.5.4 Test Release
Date: Tue, 20 Nov 2007 04:41:48 -0400 (AST)

> i see warnings about __restrict_arr being redefined in lib/posix/regex.h ...
> do you need to sync up latest regex code from gnulib ?

Probably. Thanks.

> src/search.c:check_multibyte_string() calls wcrtomb() on a const string but
> wcrtomb() in most cases will be modifying the first argument (which is the
> const string)

That code wasn't touched in at least 2 years. Is it easy to fix? Would you
submit a patch? :O)

> > 2) Remove known failing cases from the release
> can you iterate which those are ?  i see 2 failing tests: foad1.sh and
> yesno.sh ... seems like the foad1.sh tests show a pretty "bad" problem in
> grep that should get fixed rather than ignored ... or is my understanding of
> what is being tested incorrect ?  seems like failing "-o -i" is
> pretty "bad" ... especially as it's a regression from grep-2.5.1 ...

Yes, foad1.sh and yesno.sh. But not all the tests in these script fail. It
is easier to just remove these files from the distribution tarball, but I
think if there is an easy enough way to disable only some tests that would
be better.

The failing cases have been failing for a long time. They will be kept in
CVS and I consider them of high importance. The purpose of removing them
from the distribution is to reduce the volume of bug reports for known
bugs. I think it would be a good idea to document these bugs somewhere in
the distribution, either in the docs or in README.

> rather than rewriting yet another testsuite by hand, have you seen autotest ?
> it's an attempt by the autotools guys for streamlining test integration for
> autotool-based projects

Sounds promising! It is currently listed as experimental, but we should
keep autotest on the radar.



Tony Abou-Assaleh
Email:    address@hidden
Web site: http://tony.abou-assaleh.net

reply via email to

[Prev in Thread] Current Thread [Next in Thread]