bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: mostly-cleanup/readability/maintainability patches


From: Eric Blake
Subject: Re: mostly-cleanup/readability/maintainability patches
Date: Tue, 06 Apr 2010 07:36:23 -0600
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b1 Thunderbird/3.0.4

On 04/04/2010 01:43 AM, Jim Meyering wrote:
> +++ b/configure.ac
> @@ -128,6 +128,12 @@ if test "$gl_gcc_warnings" = yes; then
>    AC_SUBST([GNULIB_WARN_CFLAGS])
>  fi
> 
> +# By default, argmatch should fail calling usage (1).
> +AC_DEFINE([ARGMATCH_DIE], [usage (1)],
> +          [Define to the function xargmatch calls on failures.])
> +AC_DEFINE([ARGMATCH_DIE_DECL], [void usage (int _e)],
> +          [Define to the declaration of the xargmatch failure function.])

Should that be usage (EXIT_FAILURE), rather than usage (1)?

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]