bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] grep: prefer fgets to printf, _ to gettext


From: Jim Meyering
Subject: Re: [PATCH] grep: prefer fgets to printf, _ to gettext
Date: Sun, 01 Jan 2012 11:46:20 +0100

Paul Eggert wrote:
> Here's a proposed minor cleanup patch.
>
> * lib/colorize.h (print_end_colorize):
> * lib/ms/colorize-impl.c (print_end_colorize):
> Use fputs instead of printf.
> * src/main.c (usage): Likewise.  Use _ instead of gettext.
...
> -  printf ("%s", sgr_end);
> +  fputs (sgr_end, stdout);
...
> -    printf ("%s", sgr_end);
> +    fputs (sgr_end, stdout);
...
> -      printf ("%s", gettext (before_options));
> +      fputs (_(before_options), stdout);
...
> -      printf ("%s", _(after_options));
> +      fputs (_(after_options), stdout);

Thanks.  Those all look fine.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]