bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] grep: -r with no args now searches "."


From: Paolo Bonzini
Subject: Re: [PATCH] grep: -r with no args now searches "."
Date: Tue, 03 Jan 2012 09:17:01 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0

On 01/02/2012 01:22 PM, Paul Eggert wrote:
This is not an upward compatible change, since "grep -r PAT<file"
will no longer search standard input, but that's OK; nobody should
be using "grep -r" that way anyway.

... except people which use GREP_OPTIONS.

We should first warn about this, and then change it after a year or so.

In addition, it seems to me that while this behavior would be fine for -r/-R, keeping a default of stdin would be better for --directories=recurse, which is currently a synonym.

Please revert, and let more time pass in the future before installing backwards-incompatible changes.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]