bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 6/9] dfa: remove dead assignment


From: Jim Meyering
Subject: Re: [PATCH 6/9] dfa: remove dead assignment
Date: Tue, 03 Jan 2012 10:33:30 +0100

Paolo Bonzini wrote:
> * src/dfa.c (transit_state): transit_state_consume_1char will clear follows,
> do not do this ourselves.

Well spotted.
That parameter is output-only; it is initially cleared via
transit_state_consume_1char->copy->memset.

ACK.

>  src/dfa.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/src/dfa.c b/src/dfa.c
> index 9b714c7..4644cab 100644
> --- a/src/dfa.c
> +++ b/src/dfa.c
> @@ -3140,7 +3140,6 @@ transit_state (struct dfa *d, int s, unsigned char 
> const **pp)
>
>    while (*pp - p1 < maxlen)
>      {
> -      follows.nelem = 0;
>        transit_state_consume_1char(d, s1, pp, NULL, &mbclen, &follows);
>
>        for (i = 0; i < nelem ; i++)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]