[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC/RFT PATCH 00/11] Differentiate ^/$ from \` and \' in grep -z mo
From: |
Jim Meyering |
Subject: |
Re: [RFC/RFT PATCH 00/11] Differentiate ^/$ from \` and \' in grep -z mode |
Date: |
Wed, 04 Jan 2012 12:24:49 +0100 |
Paolo Bonzini wrote:
> this series is a pretty heavy refactoring of how anchors work in dfa.c.
> The main objective is to implement ^, $, \` and \' correctly when grep
> -z is in use. In particular, ^ and $ will match a newline character in
> the middle of a NULL-delimited sequence. This is backwards-incompatible.
...
> dfa: fix corner case with anchors
> dfa: introduce contexts for the values in d->success
> dfa: change newline/letter to a single context value
> dfa: refactor common context computations
> dfa: change meaning of a state context
> dfa: remove useless check
> dfa: make repetitive code *really* repetitive
> dfa: remove redundant line constraints
> dfa: rename "newline" to "buffer delimiter"
> dfa: introduce bufdelim context
> dfa: introduce BEGBUF/ENDBUF
Thanks for all that work.
Just a heads up that I probably won't be able to do much
more grep review work this week, due to other commitments:
a coreutils release is imminent and parted needs attention.
- [PATCH 02/11] dfa: introduce contexts for the values in d->success, (continued)
- [PATCH 02/11] dfa: introduce contexts for the values in d->success, Paolo Bonzini, 2012/01/04
- [PATCH 04/11] dfa: refactor common context computations, Paolo Bonzini, 2012/01/04
- [PATCH 03/11] dfa: change newline/letter to a single context value, Paolo Bonzini, 2012/01/04
- [PATCH 05/11] dfa: change meaning of a state context, Paolo Bonzini, 2012/01/04
- [PATCH 06/11] dfa: remove useless check, Paolo Bonzini, 2012/01/04
- [PATCH 07/11] dfa: make repetitive code *really* repetitive, Paolo Bonzini, 2012/01/04
- [PATCH 08/11] dfa: remove redundant line constraints, Paolo Bonzini, 2012/01/04
- [PATCH 11/11] dfa: introduce BEGBUF/ENDBUF, Paolo Bonzini, 2012/01/04
- [PATCH 09/11] dfa: rename "newline" to "buffer delimiter", Paolo Bonzini, 2012/01/04
- [PATCH 10/11] dfa: introduce bufdelim context, Paolo Bonzini, 2012/01/04
- Re: [RFC/RFT PATCH 00/11] Differentiate ^/$ from \` and \' in grep -z mode,
Jim Meyering <=