Re: [PATCH 1/8] dfa: remove useless check

[Jim Meyering]

Paolo Bonzini wrote:
> * src/dfa.c (state_index): There is nothing that is a newline *and*
> a letter.  Remove redundant call to SUCCEEDS_IN_CONTEXT.

ACK.

>  src/dfa.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/src/dfa.c b/src/dfa.c
> index 8dbadd5..11cb726 100644
> --- a/src/dfa.c
> +++ b/src/dfa.c
> @@ -1964,8 +1964,7 @@ state_index (struct dfa *d, position_set const *s, int 
> newline, int letter)
>          constraint = s->elems[j].constraint;
>          if (SUCCEEDS_IN_CONTEXT(constraint, newline, 0, letter, 0)
>              || SUCCEEDS_IN_CONTEXT(constraint, newline, 0, letter, 1)
> -            || SUCCEEDS_IN_CONTEXT(constraint, newline, 1, letter, 0)
> -            || SUCCEEDS_IN_CONTEXT(constraint, newline, 1, letter, 1))
> +            || SUCCEEDS_IN_CONTEXT(constraint, newline, 1, letter, 0))
>            d->states[i].constraint |= constraint;
>          if (! d->states[i].first_end)
>            d->states[i].first_end = d->tokens[s->elems[j].index];