[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#16911: [PATCH] grep: fix bugs with -i and titlecase
From: |
Jim Meyering |
Subject: |
bug#16911: [PATCH] grep: fix bugs with -i and titlecase |
Date: |
Mon, 3 Mar 2014 19:18:20 -0800 |
On Sun, Mar 2, 2014 at 11:27 PM, Paul Eggert <address@hidden> wrote:
> [I've reopened 16911 since the bug's not fixed on OS X.]
>
> Here's my guess. In glibc's en_US locale, 'Lj' is considered to be both
> uppercase and lowercase; but in OS X's en_US locale, it's considered to be
> neither uppercase nor lowercase. If so, the attached gnulib patch should
> fix the problem (though I can't easily test this). Could you please give it
> a try?
Hi Paul,
That patch does indeed solve the problem.
> By the way, I'd like to remove the need for grep's local differences from
> the glibc regex code. I assume it's there only to pacify GCC's warnings
> flags, and we can do that with pragmas in gnulib. One fix at a time,
> though.
You're right. It was only to avoid warnings from gcc, and using #pragmas
is a better approach, in a project like grep where we rarely modify that code.
Thanks!
Jim
bug#16911: grep: fix bugs with -i and titlecase, Paul Eggert, 2014/03/07