bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#17095: [PATCH] grep: proceed the `beg' pointer after exact matched i


From: Jim Meyering
Subject: bug#17095: [PATCH] grep: proceed the `beg' pointer after exact matched in KWSet
Date: Thu, 27 Mar 2014 12:06:36 -0700

On Thu, Mar 27, 2014 at 12:05 PM, Jim Meyering <address@hidden> wrote:
> On Thu, Mar 27, 2014 at 5:54 AM, Norihiro Tanaka <address@hidden> wrote:
>> Jim,
>>
>> Thanks, I have added the comments to the patch and have slightly
>> modified the comment you wrote.
>
> Norihiro,
>
> I see you also added a test case.  Thanks for that.  I've amended that
> commit log message with a corresponding ChangeLog entry.
>
> You're right that "beg" must not be advanced, so I have adjusted the
> patch to factor out the call to dfaexec without changing "beg".  I've also
> augmented the first test to require an exact match of the sole input line,
> and changed the other test to require not just a nonzero exit, but $? = 1.

And here's the patch:

Attachment: k.txt
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]