bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#16842: [PATCH] Use mbrtowc_cache in DFA engine


From: Paul Eggert
Subject: bug#16842: [PATCH] Use mbrtowc_cache in DFA engine
Date: Fri, 28 Mar 2014 09:36:11 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

Thanks for the review and the fixes. I found a couple more things. First, it's not portable to cast wint_t * to wchar_t *, since the pointed-to types might be different sizes or representations. Second, we can put the cache directly in the struct dfa, saving the overhead of doing a separate malloc.

The attached further patch should address these problems. I pushed this, along with the earlier two patches in this sequence, and am marking this as done.


Attachment: 0003-dfa-avoid-an-indirection-and-port-wint_t-usage.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]