bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#17157: [PATCH 1/5] Partially revert "dfa: improve port to freestandi


From: Paolo Bonzini
Subject: bug#17157: [PATCH 1/5] Partially revert "dfa: improve port to freestanding DJGPP"
Date: Wed, 02 Apr 2014 09:10:42 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

Il 01/04/2014 20:36, address@hidden ha scritto:
Not really such a good idea. mbsupport.h is used in multiple places
in gawk to define if MBS support is availble. It needs to stay
that way. Since we're discussing keeping dfa simple in both its
environments, then it needs to be in a header that only dfa uses.

At the moment, the best candidate is xalloc.h, which differs somewhat
grep vs. gawk.

But here too, in reality that file is mainly for allocation stuff
and dfa portability doesn't really belong there.

I respectfully suggest dfaconfig.h (or dfacustom.h) with

        #ifdef GAWK
        #ifndef HAVE_SETLOCALE
        #define selocale(x, y)  NULL
        #endif
        #define static_assert(cond) ...
        #endif

as the initial contents.

Couldn't gawk's dfaconfig.h include gawk's mbsupport.h?

Paolo





reply via email to

[Prev in Thread] Current Thread [Next in Thread]