[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#17230: [PATCH 1/2] grep: may also use Boyer-Moore algorithm for case

From: Paul Eggert
Subject: bug#17230: [PATCH 1/2] grep: may also use Boyer-Moore algorithm for case-insensitive matching
Date: Tue, 22 Apr 2014 21:20:59 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

Thanks much for this performance improvement. I puzzled for a while to figure out what was going on, and was confused by that tricky macro expansion. Nowadays functions are typically not significantly slower than macros, so unless there's a major performance difference I'd prefer to use functions. I installed the performance improvement patch and followed up with the attached patch, which uses C functions instead of macros and which coalesces some of the near-duplicate code. The followup patch also includes some comments to try to explain the new functions.

Attachment: 0001-kwset-simplify-Boyer-Moore-with-unibyte-i.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]