[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#17336: [PATCH] grep: warning to be uninitialized with -Wall

From: Paul Eggert
Subject: bug#17336: [PATCH] grep: warning to be uninitialized with -Wall
Date: Thu, 24 Apr 2014 21:52:59 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

Norihiro Tanaka wrote:
I can't find any reasons that `accept' variable should be uninitialized.

Two reasons. First, if we add initialization to the source, that might cause some compilers to generate less-efficient code. More important, adding initialization might cause some human readers of the code to become confused, and to think that the initialization is necessary.

If you're using -Wall, I suggest configuring with './configure --enable-gcc-warnings', as that should avoid the problem.

Come to think of it, perhaps we should get rid of the '#ifdef lint' code here, as in the attached patch. These days GCC is smart enough to figure this stuff out without that code, if one uses --enable-gcc-warnings. This works for me with GCC 4.9.0 and with GCC 4.8.2. --enable-gcc-warnings is intended for relatively-recent GCC versions; we needn't worry about supporting old versions.

Attachment: Wall.diff
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]