[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#17350: [PATCH] grep: speed up for a case to repeat failure in DFA af

From: Paul Eggert
Subject: bug#17350: [PATCH] grep: speed up for a case to repeat failure in DFA after success in kwset
Date: Wed, 30 Apr 2014 00:10:26 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

Thanks for working on that. A few comments. First, the ChangeLog entries can be improved; I put a proposed rewrite of them into the first two attached patches (the code's the same). Second, building with --enable-gcc-warnings causes a complaint about dfasuperset needing to be declared pure. Third, EGexecute still has quite a bit of duplicate code, even with the patch. I took at shot at simplifying it (and fixing the 2nd problem) in the third attached patch. This passes "make check" but I have not benchmarked it.

Attachment: 0001-grep-simplify-superset.patch
Description: Text document

Attachment: 0002-grep-adjust-timing-back-to-kwset-when-dfaisfast-is-t.patch
Description: Text document

Attachment: 0003-grep-simplify-EGexecute-further.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]