[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#16757: [PATCH 1/2] search for pcre via pkg-config

From: Paul Eggert
Subject: bug#16757: [PATCH 1/2] search for pcre via pkg-config
Date: Mon, 06 Apr 2015 16:12:59 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 04/06/2015 12:14 AM, Mike Frysinger wrote:
On 25 May 2014 01:14, Paul Eggert wrote:
--- a/m4/pcre.m4
+++ b/m4/pcre.m4

+  if test $test_pcre = yes; then
the previous code quoted test_pcre ... i guess previously it was normalized into
"yes" and "no", but seems pretty cheap & easy to be resilient ?

For gnulib we tend to prefer omitting the quotes when they're not needed, to make the code *less* resilient (i.e., to find bugs better....). A style thing, admittedly.

+    PKG_CHECK_MODULES([PCRE], [libpcre], [],
+      [if test -r /usr/include/pcre/pcre.h &&
+          test ! -r /usr/include/pcre.h
+       then
ugh, but i guess i don't really care since this is the default and it can go
poking around in whatever terrible way it wants.

That was fixed in <http://bugs.gnu.org/16757#26>.

+         PCRE_CFLAGS=-I/usr/include/libpng
png eh ?

This was also fixed.

+    if test "$pcre_cv_have_pcre_compile" = yes; then
+      use_pcre=yes
+    else
        AC_MSG_WARN([AC_PACKAGE_NAME will be built without pcre support.])
ideally this would error out if the user passed --enable-perl-regexp.  the
test_pcre setup would have to pick like "auto" though in the default case.

Thanks, fixed by the attached further patch. I've installed this and the earlier patches in this sequence, and am marking this as done.

Attachment: 0001-build-improve-pkg-config-doc-and-error-handling.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]