[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#20526: BUG: text file is detected as binary

From: Paul Eggert
Subject: bug#20526: BUG: text file is detected as binary
Date: Thu, 07 May 2015 13:07:20 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 05/07/2015 10:47 AM, Sebastian Pöhn wrote:

Thanks for this fast feedback. Your explanation sounds very reasonable. As you may have noticed this a makefile out of openwrt with is mainlined there.

1) I downgraded to grep 2.20. Issue is gone with the same environment. So this is in my eyes a regression.

Not really, as Openwrt is relying on undefined behavior. The spec for grep has never defined what grep does when you feed it binary data that is not properly encoded for the current locale. Different versions of grep (and we're not just talking GNU grep here, but other implementations) do different things. Some grep implementations dump core. These behaviors all conform to the spec. (Well, GNU grep isn't supposed to dump core, but older versions of GNU grep are buggy and will dump core sometimes anyway, so you'll need good luck with them.)

2) I will also open a report at fedora, maybe the use some strange setting in building the new packet.

Nowadays most people are using UTF-8, so I suggest encoding the Makefiles in UTF-8 and specifying a UTF-8 locale when you build. Another possibility is the attached hack (I haven't tried it). The most conservative course would be to insist that Makefiles be ASCII, although ....

3) I will send a short notice to openwrt asking if they think it is fine to use ë or ö. I personally have a strong opinion on that ;)

Don't blame you a bit.

Attachment: openwrt.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]