[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#20526: grep BUG: text file is detected as binary

From: Paul Eggert
Subject: bug#20526: grep BUG: text file is detected as binary
Date: Tue, 5 Jan 2016 23:33:39 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0

Norihiro Tanaka wrote:
I see that it is good idea, but I propose minor change for your
fix.  Perhaps, it will be what you want.

I think the problem here is that the code was not computing unibyte_mask correctly; that is, the comment for unibyte_mask is correct, and usage of unibyte_mask is correct, but unibyte_mask was sometimes initialized incorrectly in unusual locales. I installed the attached patch to try to fix that. Computing an optimal unibyte_mask (for a reasonable definition of "optimal") is likely more trouble than it is worth.

Attachment: 0001-Fix-calculation-of-unibyte_mask.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]