[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24262: [PATCH 2/2] dfa: support not newline_anchor of regex

From: Paul Eggert
Subject: bug#24262: [PATCH 2/2] dfa: support not newline_anchor of regex
Date: Fri, 2 Sep 2016 15:35:22 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

Norihiro Tanaka wrote:
However, the patch adds an argument to dfasyntax().   To synchronize
between grep and dfa easily, I expect it is applied before dfa is moved
to gnulib.

Since we're already changing the DFA API already, how about if we have a flags arg that combines all these little Boolean arguments? That will make future changes less disruptive. Although the existing code supports any newline terminator, in practice only '\0' and '\n' are useful, so it's really just a boolean.

Most of the changes in your proposed patch are subsumed by the changes for multithreading, so the patch can be simplified now. I installed the attached, and plan to follow up shortly about the corresponding Gawk changes that I'll propose.

Attachment: 0001-dfa-new-option-for-anchored-searches.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]