[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#29123: [PATCH] grep: mark matchers table const

From: Zev Weiss
Subject: bug#29123: [PATCH] grep: mark matchers table const
Date: Fri, 3 Nov 2017 09:32:57 -0500
User-agent: NeoMutt/20171013

On Fri, Nov 03, 2017 at 03:45:07AM CDT, Paul Eggert wrote:
Zev Weiss wrote:

-static struct
+static const struct
   char const name[12];

There's already a const after the } at the end of the struct, so this 'const' is not needed. The usual style in 'grep' is to put the 'const' after the type, not before it.

Come to think of it, the 'const' in front of 'name' is also a duplicate, so I installed the attached.

Ah, missed that, sorry (had seen it written as 'static const struct'
earlier in the file on 'color dict') -- nevermind on this one, obviously.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]