bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#29124: [PATCH] grep: simplify out_file handling


From: Zev Weiss
Subject: bug#29124: [PATCH] grep: simplify out_file handling
Date: Sat, 4 Nov 2017 16:00:29 -0500
User-agent: NeoMutt/20171013

On Sat, Nov 04, 2017 at 01:55:51AM CDT, Paul Eggert wrote:
Zev Weiss wrote:
I'm wondering how robust (paranoid?) grep really needs to be in the face of concurrent filesystem modifications.

Not that paranoid. Still, it's better for grep to avoid races when it's easy, as is the case here.

OK, how about the attached patch then -- it both avoids updating out_file during directory recursion (simpler, and perhaps a tiny performance win) and doesn't add any syscalls or races.


Zev

Attachment: 0001-grep-simplify-out_file-handling.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]