bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#34054: Error in compilation of pcresearch if we have no pcre library


From: Paul Eggert
Subject: bug#34054: Error in compilation of pcresearch if we have no pcre library
Date: Sun, 20 Jan 2019 10:02:41 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

Jim Meyering wrote:
Technically, we could fix it by adding more ifdefs, but I think it
would not be worthwhile to accommodate this use case.

I looked into this and discovered that fixing this can actually simplify the source code by removing the need for the "We can't get here" glitch in pcresearch.c. Although the fix does add complexity elsewhere so that the total number of ifdefs and ifs remains the same, overall grep gets a bit simpler and cleaner with the fix so I took the liberty of installing it (attached).

Attachment: 0001-grep-simplify-pcresearch.c-ifdefs.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]