[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch] 1.8.3: Makefile fixes

From: Maciej W. Rozycki
Subject: [patch] 1.8.3: Makefile fixes
Date: Thu, 24 Oct 2002 14:03:24 +0200 (MET DST)


 Here is a patch that fixes a few Makefile oddities:

2002-10-24  Maciej W. Rozycki  <address@hidden>

        * Makefile.in (binprefix): Remove unused definition.
        (manprefix): Likewise.
        (mandir): Define.
        (man3dir): Use $(mandir).

        * Makefile.in (libgdbm_compat.la): Link against libgdbm.la.

 The most important is the libgdbm_compat.la change -- it makes libtool
record the libgdbm_compat's dependency on libgdbm.  It will make a user's
program link against libgdbm_compat pick libgdbm when libtool is used. 
Also for correct dynamic linker implementations (like the one of glibc)
the dependency is recorded in the shared libgdbm_compat making the picking
automatic (by ld and ld.so) even with no libtool assistance.

 The mandir change allows a user to override the variable on the make's
command line, with no need to re-run ./configure.  This is an expected
behaviour for GNU packages -- see `info standards'.

 The *prefix removals are cosmetical.

 Please apply the patch.

 I have two additional questions:

1. Why did you name the installation prefix INSTALL_ROOT?  It is expected
to be named DESTDIR -- see `info standards'.

2. This ChangeLog entry makes me worry:

Fri Sep 27 16:12:44 PDT 2002    Jason Downs (address@hidden)

        * Makefile.in: Remove `info' target from all, since we don't even
          bother installing the one we built anyway.

The info file does get installed.  The "install" goal depends on
"gdbm.info", so it'll get rebuilt eventually if out of date, but `make
install' may be run with different (e.g. root) privileges and rebuilding
sources may be undesireable then.  How about adding "gdbm.info" to the
list of prerequisites for "install"?


+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+        e-mail: address@hidden, PGP key available        +

diff -up --recursive --new-file gdbm-1.8.3.macro/Makefile.in 
--- gdbm-1.8.3.macro/Makefile.in        2002-10-08 16:09:12.000000000 +0000
+++ gdbm-1.8.3/Makefile.in      2002-10-23 21:54:03.000000000 +0000
@@ -32,8 +28,6 @@ LDFLAGS = @LDFLAGS@
 # Common prefix for installation directories
 prefix = @prefix@
 exec_prefix = @exec_prefix@
-binprefix = $(exec_prefix)
-manprefix = $(prefix)
 # Directory in which to put libgdbm.a.
 libdir = @libdir@
@@ -41,7 +35,8 @@ libdir = @libdir@
 includedir = @includedir@
 # Info and man directories.
 infodir = @infodir@
-man3dir = @mandir@/man3
+mandir = @mandir@
+man3dir = $(mandir)/man3
 manext = 3
 #### End of system configuration section. ####
@@ -161,7 +151,7 @@ libgdbm.la: $(LOBJS) gdbm.h
 libgdbm_compat.la: $(C_LOBJS) gdbm.h
        rm -f libgdbm_compat.la
        $(LIBTOOL) --mode=link $(CC) -o libgdbm_compat.la -rpath $(libdir) \
-               -version-info $(SHLIB_VER) $(C_LOBJS)
+               -version-info $(SHLIB_VER) $(C_LOBJS) libgdbm.la
 gdbm.h:        gdbm.proto gdbmerrno.h gdbm.proto2
        rm -f gdbm.h

reply via email to

[Prev in Thread] Current Thread [Next in Thread]