bug-groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

groff-1.18.1.1/src/devices/grops/ps.cc: bad call to fgets


From: d binderman
Subject: groff-1.18.1.1/src/devices/grops/ps.cc: bad call to fgets
Date: Tue, 29 Dec 2009 15:16:16 +0000


Hello there,

I just had a look at source code file groff-1.18.1.1/src/devices/grops/ps.cc,
around line 740, where there is code

  char buf[256];
  while (fgets(buf, 512, fp) != 0) {

It seems slightly less than optimal to me to allow 512 characters
into a buffer of size only 256 bytes. Suggest code rework.

Regards

David Binderman

                                          
_________________________________________________________________
View your other email accounts from your Hotmail inbox. Add them now.
http://clk.atdmt.com/UKM/go/186394592/direct/01/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]