[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #44768] gdiffmk(1) is not Solaris 10 /bin/sh compatible - PATCH pro
[bug #44768] gdiffmk(1) is not Solaris 10 /bin/sh compatible - PATCH provided
Sat, 02 May 2015 15:23:53 +0000
Mozilla/5.0 (X11; Linux x86_64; rv:37.0) Gecko/20100101 Firefox/37.0
Follow-up Comment #23, bug #44768 (project groff):
Here is a new patch.
As Peter said, both GNU diff and Solaris diff support -D, but #ifndef / #endif
are treated differently (GNU adds a '!' in the #endif). The easiest way to
solve this problem seems to modify the regexp (currently either a '!' or a
'not' was mandatory).
2. test -ef
OK ls -i is not the solution, stat is not posix, so I proceeded as follows:
- Test if the shell supports test -ef
- Test if bash is available, and use it by defautl in gdiffmk (otherwise we
In gdiffmk, if both tests were not successful, the option to pass a third file
as the output is disabled (gdiffmk returns an error, make check will fail).
I don't think that ! are the problem, but the space after the exclamation mark
is clearly not correct. I forgot to remove one space.
Peter, Mike, could you please test?
Additional Item Attachment:
File name: bug_44768_patch_2.patch Size:3 KB
Reply to this item at:
Message sent via/by Savannah
- [bug #44768] gdiffmk(1) is not Solaris 10 /bin/sh compatible - PATCH provided,
Bertrand Garrigues <=