[bug #55335] preconv produces CR CR LF end-of-line on MS-Windows

[Eli Zaretskii]

URL:
  <https://savannah.gnu.org/bugs/?55335>

                 Summary: preconv produces CR CR LF end-of-line on MS-Windows
                 Project: GNU troff
            Submitted by: eliz
            Submitted on: Sun 30 Dec 2018 05:49:50 PM IST
                Category: Preprocessor preconv
                Severity: 3 - Normal
              Item Group: Incorrect behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

When compiled for MS-Windows, preconv reads its input in binary mode, thus
leaving the CR characters of the CR LF end-of-line marker unconverted to the
Unix LF-only format.  However, the output is written in the default text mode,
which adds another CR before LF, thus producing files with an extra CR.  This
causes pic (and possibly other preprocessors) to complain about "invalid input
character code 13".

The solution is to switch stdout to binary mode when needed.  The proposed
patch is in the attachment.




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sun 30 Dec 2018 05:49:50 PM IST  Name: preconv_binary.dif  Size: 613B  
By: eliz

<http://savannah.gnu.org/bugs/download.php?file_id=45793>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55335>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/