[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #57592] [PATCH] tmac/<files containing a ".nx" request>: Add a warn
[bug #57592] [PATCH] tmac/<files containing a ".nx" request>: Add a warning
Tue, 14 Jan 2020 07:18:03 -0500 (EST)
Mozilla/5.0 (X11; OpenBSD amd64; rv:71.0) Gecko/20100101 Firefox/71.0
Update of bug #57592 (project groff):
Severity: 3 - Normal => 1 - Wish
Follow-up Comment #1:
I strongly agree with Steffen Nurpmeso on this one. Let me quote what he
wrote on the mailing list:
"I do not think this is a good idea in general, since this means you cannot
blindly include some file to ensure it is present or not. Say you want to
include some picture in a report and include the macro set which allows that,
but it was already sourced (maybe due to some condition) in another macro set.
Now you have a pointless warning. The way it is done right now is how most
languages ensure that files get included once only once [...]"
Besides, there is no danger in including a file twice as long as the file acts
in an idempotent manner. So Steffen explained above why the patch is
detrimental, and this additional observation means that it has very little
benefit, if any.
Finally, this is complicating code without a good reason, which also isn't a
Can someone provide an OK to close this ticket as "invalid"?
Reply to this item at:
Message sent via Savannah