[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #60926] [mm] use of AT with ms.cov provokes warnings
From: |
G. Branden Robinson |
Subject: |
[bug #60926] [mm] use of AT with ms.cov provokes warnings |
Date: |
Fri, 16 Jul 2021 21:02:12 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 |
Update of bug #60926 (project groff):
Status: In Progress => Fixed
Open/Closed: Open => Closed
Planned Release: None => 1.23.0
_______________________________________________________
Follow-up Comment #1:
commit 4fd984adc9468080aa2c7e762f83dddb28790bd1 (HEAD -> master,
origin/master, origin/HEAD)
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date: Sat Jul 17 10:19:16 2021 +1000
[mm]: Refactor author title handling.
* contrib/mm/m.tmac (AU): Emit error diagnostic and skip remainder of
macro definition if called without arguments; this will keep people
familiar with the ms package from getting incorrect and surprising
output. Initialize `cov*at!` array element to zero for current author
number (`AT` already updates it).
* contrib/mm/mm/ms.cov (cov@print-authors): Enforce requirement
documented in groff_mm(7) that .AU is mandatory if .COVER is used.
Emit diagnostic if `cov*au` is not defined, and skip remainder of
macro definition. Test for existence of authors' titles differently;
now that `cov*at!` (a count of titles for the current author) is
guaranteed to be initialized, we can use it as part of a while loop
condition, instead of the hard-coded "9" as an arbitrary limit on the
allowed quantity of author titles (though surely even that is
obnoxiously high in practice), and more importantly avoid using a \w
escape to measure the width of the interpolation of a potentially
undefined string. Use `nop` to indent text output. Delete apparent
typo causing `mac` warning with respect to undefined `.` macro.
Introduce temporary strings for the author and author title "loop
indices" to shorten and clarify logic. Remove them when done.
Fixes <https://savannah.gnu.org/bugs/?60926>.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?60926>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/