[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #61315] [PATCH] several source files don't include <config.h> first

From: G. Branden Robinson
Subject: [bug #61315] [PATCH] several source files don't include <config.h> first
Date: Sun, 10 Oct 2021 17:00:47 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Update of bug #61315 (project groff):

                  Status:             In Progress => Fixed                  
             Open/Closed:                    Open => Closed                 
         Planned Release:                    None => 1.23.0                 


Follow-up Comment #5:

commit 0c7866632d0490ac452de609c3c4d624a170c8a6
Author: Paul Eggert <eggert@cs.ucla.edu>
Date:   Sat Oct 9 00:38:54 2021 -0700

    Include <config.h> before any standard headers.
    Gnulib requires that files that might use Gnulib features (which pretty
    much means every C or C++ source file) must include <config.h> first.
    Arrange for that.  This will be needed once Groff updates to the latest
    Gnulib; see Bjarni Ingi Gislason's problem report in:
    The only exception I can see is src/utils/addftinfo/guess.cpp, which
    does not include any standard include file either directly or
    indirectly, and so need not include <config.h>.
    * src/devices/xditview/Dvi.c:
    * src/devices/xditview/font.c:
    * src/devices/xditview/lex.c:
    * src/devices/xditview/page.c:
    * src/devices/xditview/parse.c:
    * src/libs/libbib/map.c:
    * src/libs/libgroff/change_lf.cpp:
    * src/libs/libgroff/cmap.cpp:
    * src/libs/libgroff/cset.cpp:
    * src/libs/libgroff/fmod.c:
    * src/libs/libgroff/getcwd.c:
    * src/libs/libgroff/lf.cpp:
    * src/libs/libgroff/ptable.cpp:
    * src/libs/libgroff/quotearg.c:
    * src/libs/libxutil/DviChar.c:
    * src/libs/libxutil/XFontName.c:
    * src/libs/libxutil/xmalloc.c:
    * src/utils/indxbib/signal.c: Do it.
    [Fixes <https://savannah.gnu.org/bugs/?61315>. --GBR]


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]