bug-groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #61302] [tests] non-portable use of echo


From: G. Branden Robinson
Subject: [bug #61302] [tests] non-portable use of echo
Date: Thu, 28 Oct 2021 01:28:10 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Update of bug #61302 (project groff):

                  Status:             In Progress => Fixed                  
             Open/Closed:                    Open => Closed                 
         Planned Release:                    None => 1.23.0                 
                 Summary:            Build errors => [tests] non-portable use
of echo

    _______________________________________________________

Follow-up Comment #8:

The only groff problems turned out to be my non-portable use of echo in some
test scripts.

I see the pnmcrop diagnostics on Mac OS X as well, but they are harmless; the
images linked by the pic-*.html and webpage.html files look intact and
correct.  It appears that some versions of pnmcrop ignore the command's
`-quiet` flag, which pre-grohtml is definitely passing to it.  So, not our
problem.


commit 244e55f660e33cdb84cec3baea7eca69279cf579
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sat Oct 9 17:51:50 2021 +1100

    [tests]: Fix portability problems in 2 tests.
    
    * src/roff/groff/tests/break_zero-length_output_line_sanely.sh:
    * tmac/tests/s_PN-works.sh: Migrate from `echo` to `printf` for test
      inputs containing backslashes to be interpreted literally.
    
    Fixes part of <https://savannah.gnu.org/bugs/?61302>.  Thanks to Deri
    James for identifying the problem.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61302>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]