[bug #62062] [sboxes] uses a few ms registers unconditionally

[G. Branden Robinson]

URL:
  <https://savannah.gnu.org/bugs/?62062>

                 Summary: [sboxes] uses a few ms registers unconditionally
                 Project: GNU troff
            Submitted by: gbranden
            Submitted on: Wed 16 Feb 2022 08:27:15 AM UTC
                Category: Macro - others/general
                Severity: 3 - Normal
              Item Group: Warning/Suspicious behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

sboxes.tmac uses a few ms registers selectively.  However, if they're not set,
it doesn't seem to ruin the package's utility, at least according to the crude
experiments I did.


$ tg -msboxes -z EXPERIMENTS/sbox.groff 
troff: backtrace:
'/home/branden/src/GIT/groff/build/../contrib/sboxes/sboxes.tmac':118: macro
'BOXSTART'
troff: backtrace: file 'EXPERIMENTS/sbox.groff':4
troff:EXPERIMENTS/sbox.groff:4: warning: register '0:li' not defined
troff: backtrace:
'/home/branden/src/GIT/groff/build/../contrib/sboxes/sboxes.tmac':121: macro
'BOXSTART'
troff: backtrace: file 'EXPERIMENTS/sbox.groff':4
troff:EXPERIMENTS/sbox.groff:4: warning: register 'FM' not defined
troff: backtrace:
'/home/branden/src/GIT/groff/build/../contrib/sboxes/sboxes.tmac':122: macro
'BOXSTART'
troff: backtrace: file 'EXPERIMENTS/sbox.groff':4
troff:EXPERIMENTS/sbox.groff:4: warning: register 'HM' not defined
troff: backtrace:
'/home/branden/src/GIT/groff/build/../contrib/sboxes/sboxes.tmac':124: macro
'BOXSTART'
troff: backtrace: file 'EXPERIMENTS/sbox.groff':4
troff:EXPERIMENTS/sbox.groff:4: warning: register 'bx*PD' not defined


We can probably shift all these into bx* bespoke registers, perhaps with more
generalized names, initializing them with the values of the ms registers if
those are defined.

Maybe we should rename the package's name space prefix to "sboxes" while we're
at it?

If that doesn't work, I guess I'll need to revert a recent commit after all.


commit 26dc01acc81b363e505a95574126b66f96a9445c
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sun Feb 6 02:50:01 2022 +1100

    [sboxes]: Stop requiring ms package.
    
    * sboxes.tmac: Stop requiring ms package.  As the documentation says,
      it's not necessary; sboxes will simply take advantage of it if it is.
      Problem introduced by me in commit f1f047013, 17 October.  Append to
      ms's `fn@print-sep` and `par*start` macros only if the `GS` register
      exists, so that warnings aren't thrown when ms is not loaded.





    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?62062>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/