[bug #63924] man wrapper for system package infinitely recurses

[G. Branden Robinson]

URL:
  <https://savannah.gnu.org/bugs/?63924>

                 Summary: man wrapper for system package infinitely recurses
                   Group: GNU roff
               Submitter: gbranden
               Submitted: Tue 14 Mar 2023 04:43:52 AM UTC
                Category: Macro - others/general
                Severity: 5 - Blocker
              Item Group: Incorrect behaviour
                  Status: In Progress
                 Privacy: Public
             Assigned to: gbranden
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Tue 14 Mar 2023 04:43:52 AM UTC By: G. Branden Robinson <gbranden>
Found a blocker, and it's my fault.


commit fdac25937ff4a1c81366e0fedcf66271e105d7dd
Author:     G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Mon Jul 5 23:02:18 2021 +1000
Commit:     G. Branden Robinson <g.branden.robinson@gmail.com>
CommitDate: Tue Jul 6 19:00:14 2021 +1000

    [mandoc]: Reflect man rename in package and test.
    
    * tmac/tmac.an (tmac/stamp-wrap): Macro-source `an.tmac` in the man
      wrapper.
    
[...]

diff --git a/tmac/tmac.am b/tmac/tmac.am
index e966b439f..8c0c533f8 100644
--- a/tmac/tmac.am
+++ b/tmac/tmac.am
@@ -251,7 +251,7 @@ tmac/stamp-wrap:
          for m in ""$(tmac_wrap); do \
            $(RM) $(top_builddir)/tmac/$$m-wrap; \
            if test "$$m" = an; then \
-             echo .do mso andoc.tmac >>$(top_builddir)/tmac/$$m-wrap; \
+             echo .do mso an.tmac >>$(top_builddir)/tmac/$$m-wrap; \
            fi; \
            echo .cp 1 >>$(top_builddir)/tmac/$$m-wrap; \
            echo .so $(sys_tmac_prefix)$$m >>$(top_builddir)/tmac/$$m-wrap; \


That change was wrong.  We are _creating_ an.tmac here, so this causes an
infinite recursion of macro package loading.

Surprisingly enough, this isn't fatal.  Man pages even still get rendered. 
But it sure is ugly on the standard error stream.


$ gnroff -t -man /usr/share/man/man1/true.1 2>&1 >/dev/null | sort | uniq -c
   1 gtroff:/home/gbranden/lib/groff/site-tmac/an.tmac:3: error: can't open
'/usr/share/lib/tmac/an': Too many open files
 252 gtroff:/usr/share/lib/tmac/an:505: error: cannot load font 'S' for
emboldening
   1 gtroff:/usr/share/man/man1/true.1:20: warning: cannot select font 'CW'
   1 /usr/share/man/man1/true.1:41: warning: table wider than line length
minus indentation









    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63924>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/