[bug #65962] input.cpp: reduce stack limit to <=100

[Bjarni Ingi Gislason]

URL:
  <https://savannah.gnu.org/bugs/?65962>

                 Summary: input.cpp: reduce stack limit to <=100
                   Group: GNU roff
               Submitter: bjarniig
               Submitted: Sun 07 Jul 2024 02:05:36 PM UTC
                Category: Core
                Severity: 3 - Normal
              Item Group: Build/Installation
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Sun 07 Jul 2024 02:05:36 PM UTC By: Bjarni Ingi Gislason <bjarniig>
Subject: input.cpp: reduce stack limit to <=100

Directory: src/roff/troff

  Bug #65930 "[me] large values of register 'tv' cause infinite trap
recursion"

  uses about 1000 recursions before it gives up.

  I have not seen the reasoning for this high value.

  As I have noticed before, documenting the reasons for a concrete decision
is lacking in too many places in source files, which is the right place to
explain the used algorithms or concrete numbers.

  How many items in a stack are minimally needed for a correctly functioning
input file?

  I have run the build of groff with reduced values of the constant
"DEFAULT_INPUT_STACK_LIMIT"

and it needs > 25 < 50 stack elements.

If it needs more, I would suspect a bug, or a bad coding (algorithm) to be
the cause.








    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65962>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

signature.asc
Description: PGP signature