bug-groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #65980] [troff] emit diagnostic on unreadable input files


From: G. Branden Robinson
Subject: [bug #65980] [troff] emit diagnostic on unreadable input files
Date: Sat, 13 Jul 2024 16:25:48 -0400 (EDT)

Update of bug #65980 (group groff):

                  Status:               Confirmed => Fixed                  
             Assigned to:                    None => gbranden               
             Open/Closed:                    Open => Closed                 
         Planned Release:                    None => 1.24.0                 

    _______________________________________________________

Follow-up Comment #2:


commit 834afa4e0d80ff8b27b25e6aaee7ed17bcadf1fb
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sat Jul 13 13:09:21 2024 -0500

    [libgroff]: Fix Savannah #65980 (open directory).
    
    * src/libs/libgroff/searchpath.cpp (is_directory): New function uses
      stat(2) to check file name argument to see if it's a directory, and
      returns a Boolean.
    
      (search_path::open_file):
      (search_path::open_file_cautious): Use `is_directory()` before
      attempting to `fopen()` a file specification; fail and set `errno` to
      `EISDIR` if it's a directory so that the caller reports a useful
      diagnostic.
    
    * bootstrap.conf: Add gnulib `stat` module, because the story of
      POSIX and non-POSIX systems alike trying and failing to sensibly
      implement the fundamental Unix file system model is a sorry tale of
      indifference and self-owns by rock star programmers.  (Seriously, read
      the "sys/stat.h" and "stat" sections of the gnulib manual.)
    
    Fixes <https://savannah.gnu.org/bugs/?65980>.  Thanks to Dave Kemper for
    the report.




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65980>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]