[bug #66151] [troff] some requests read through newline when given no arguments

[G. Branden Robinson]

Update of bug #66151 (group groff):

                  Status:             In Progress => Fixed                  
             Open/Closed:                    Open => Closed                 
         Planned Release:                    None => 1.24.0                 

    _______________________________________________________

Follow-up Comment #2:


commit 5f2704d64abb3d04477b1f2907eabdfec19e2925
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Mon Sep 2 04:17:36 2024 -0500

    [troff]: Fix Savannah #66151.
    
    Update input token pointer appropriately when certain requests requiring
    arguments are invalidly invoked without them.
    
    * src/roff/troff/env.cpp (override_sizes):
    * src/roff/troff/input.cpp (while_request, pipe_output, system_request):
      Check for arguments: if none are present, throw warning in category
      "missing" and skip the remainder of the input line.
    
      (pipe_output, system_request): Add some assertions for paranoia's
      sake.
    
    Fixes <https://savannah.gnu.org/bugs/?66151>.


However, that commit was a botch in a different respect; one will also
want...


commit cbfa5a07c882065eb2a99e4d1dc6ea79034ec6e1
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Tue Sep 3 11:03:47 2024 -0500

    [troff]: Mitigate Savannah #66164.
    
    * src/roff/troff/input.cpp (pipe_output, system_request): Fix requests I
      broke in commit 5f2704d64a, yesterday.  Thanks to Deri James for the
      report.
    
    Begins fixing <https://savannah.gnu.org/bugs/?66164>.  (We need
    regression tests.)


...that one.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?66151>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

signature.asc
Description: PGP signature