[bug #66155] [PATCH] [man, mom] tests should adapt to discrepant pdftotext and pdfimages implementations

[G. Branden Robinson]

Update of bug #66155 (group groff):

                Category:                 General => Macro package -
others/general
                  Status:                    None => Fixed                  
             Assigned to:                    None => gbranden               
             Open/Closed:                    Open => Closed                 
         Planned Release:                    None => 1.24.0                 
                 Summary: [PATCH] test suite should confirm functionality of
pdftotext and pdfimages => [PATCH] [man,mom] tests should adapt to discrepant
pdftotext and pdfimages implementations

    _______________________________________________________

Follow-up Comment #3:


commit 1cfbd820e4dd3ee5a716b574f835ff07f798461d
Author: Sven Schober <sv3sch@gmail.com>
Date:   Mon Sep 2 20:11:53 2024 +0200

    [man]: Handle discrepant `pdf{images,totext}`.
    
    There are at least two different implementation variants for pdfimages
    and pdftotext out there: poppler's and xpdfreader.com's.
    
    * tmac/tests/an_UR-works.sh: Cope with minute syntax differences between
      these implementations in test case.
    
    Fixes <https://savannah.gnu.org/bugs/?66155> (1/2).
    
    [I tweaked the shell style. --GBR]

commit 195e2574d70661536680fc7c783e5dccbf5df58d
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sat Sep 7 20:06:50 2024 -0500

    ANNOUNCE: Acknowledge Sven.

commit 06783d46f95cde8d4c06c3bd95f87c862ace8ab6
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sat Sep 7 02:35:53 2024 -0500

    [mom]: Rename generated test file.
    
    * contrib/mom/mom.am: Rename generated test file.  It's pretty confusing
      to have "test-mom.sh.in" produce "tests-mom.sh" (note the plural).

commit 1354485bc37d66dcc3a3825c91899b3cb392e849
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sat Sep 7 02:32:10 2024 -0500

    [mom]: Tweak shell style in test script.
    
    * contrib/mom/examples/test-mom.sh.in: Tweak shell style.  Favor `[`
      command over `test` in conditional commands.  Stop quoting string
      literals that are pure alphanumeric character sequences.  Favor `$()`
      command substitution syntax over "backticks"; the groff 1.23.0
      release, with 100+ test scripts using the former syntax, established
      that every platform of interest to us supports it.  Exit with status
      1, not 255, on test failure.  The latter is not good practice per
      POSIX[1]--shells use the eighth bit of the exit status to indicate
      that a signal was received.  Rename variables for clarity.  Use AWK
      more idiomatically and frugally of the process table; it's perfectly
      capable of "grep"ping.  Use Bourne style for control structures, not
      pseudo-C.  More carefully quote variables with contents not under our
      control.  Report number of images found, instead of misreporting any
      value less than two as zero ("no images").  Exit with status 2 on
      failure to locate input files.  Quote file name in diagnostic message
      to make an empty value obvious.  Make failure output messages more
      closely resemble others in groff.
    
      (check_has_images): Prepare for patch by Sven Schober.  Poppler's
      pdfimages program writes out a header.  Strip that header from its
      output before counting lines.  Consequently make test of line count
      more precise.
    
    [1] https://pubs.opengroup.org/onlinepubs/9799919799/utilities/\
    V3_chap02.html#tag_19_08_02

commit de09e1ebc2abcde2ced51b3b3b8249bef631e107
Author: Sven Schober <sv3sch@gmail.com>
Date:   Mon Sep 2 20:11:53 2024 +0200

    [mom]: Test handles discrepant pdf{images,totext}.
    
    * examples/test-mom.sh.in: Handle discrepant `pdf{images,totext}`.
      There are at least two different implementation variants for pdfimages
      and pdftotext out there: poppler's and xpdfreader.com's.  Cope with
      minute syntax differences between these implementations in test case.
    
    Fixes <https://savannah.gnu.org/bugs/?66155> (2/2).
    
    [I tweaked the shell style. --GBR]




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?66155>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

signature.asc
Description: PGP signature