bug-groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #66290] [tbl] resurrects disabled line numbering after table region


From: G. Branden Robinson
Subject: [bug #66290] [tbl] resurrects disabled line numbering after table region
Date: Fri, 4 Oct 2024 06:52:41 -0400 (EDT)

Update of bug #66290 (group groff):

                  Status:             In Progress => Fixed                  
             Open/Closed:                    Open => Closed                 
         Planned Release:                    None => 1.24.0                 

    _______________________________________________________

Follow-up Comment #2:


commit f67cddb2efaccb5bf00238a2bef23250697a1965
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Fri Oct 4 04:56:53 2024 -0500

    [tbl]: Regression-test Savannah #66290.
    
    * src/preproc/tbl/tests/save-and-restore-line-numbering.sh: Add
      regression test for Savannah #66290.
    
    Test fails at this commit.

commit 14906bc3cfde775dd32ff49ed0cd461046c5a9c3
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Fri Oct 4 05:01:26 2024 -0500

    [tbl]: Fix Savannah #66290 (zombie `nm` revives).
    
    * src/preproc/tbl/table.cpp: Add C preprocessor macro storing the name
      of a groff register for saving the state of line numering enablement.
    
      (table::init_output): Save the value of the `.nm` register to this
      groff register.
    
      (table::do_bottom): Test the value of that register (instead of the
      saved line number itself) when deciding whether to reënable line
      numbering after leaving the table region.
    
    Fixes <https://savannah.gnu.org/bugs/?66290>.  Problem introduced by me
    in commit 950f92e25f, 28 November 2022, when fixing Savannah #61040.
    Thanks to Deri James for the report.
    
    See also <https://savannah.gnu.org/bugs/?59812>.




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?66290>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]