Bug#79515: marked as done (grub-install fails with floppy)

[Debian Bug Tracking System]

Your message dated Tue, 29 May 2001 14:56:29 -0400
with message-id <address@hidden>
and subject line Bug#75333: fixed in grub 0.5.96.1.cvs20010528-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Darren Benham
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 13 Dec 2000 13:22:07 +0000
>From address@hidden Wed Dec 13 07:22:06 2000
Return-path: <address@hidden>
Received: from uni-sb.de [134.96.252.33] 
        by master.debian.org with esmtp (Exim 3.12 1 (Debian))
        id 146BrB-0001op-00; Wed, 13 Dec 2000 07:22:05 -0600
Received: from cs.uni-sb.de (cs.uni-sb.de [134.96.252.31])
        by uni-sb.de (8.11.1/2000102300) with ESMTP id OAA09817
        for <address@hidden>; Wed, 13 Dec 2000 14:21:29 +0100 (CET)
Received: from phoenix.net.uni-sb.de (phoenix.net.uni-sb.de [134.96.250.10])
        by cs.uni-sb.de (8.11.1/2000102300) with SMTP id OAA01446
        for <address@hidden>; Wed, 13 Dec 2000 14:22:02 +0100 (CET)
Received: (qmail 27241 invoked by uid 1000); 13 Dec 2000 13:22:03 -0000
Received: from localhost (address@hidden)
  by localhost with SMTP; 13 Dec 2000 13:22:03 -0000
Date: Wed, 13 Dec 2000 14:22:03 +0100 (CET)
From: Bastian Kleineidam <address@hidden>
To: address@hidden
Subject: grub-install fails with floppy
Message-ID: <address@hidden>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Delivered-To: address@hidden

Package: grub
Version: 0.5.96.1


Hi Gordon,

running grub-install with a floppy target fails (/floppy ismounted on
/dev/fd0)
[...]
address@hidden://usr/sbin> grub-install --root-directory=/floppy '(fd0)'
/usr/sbin/grub-install: -e: command not found
/usr/sbin/grub-install: -e: command not found
expr: non-numeric argument

    GRUB  version 0.5.96.1  (640K lower / 3072K upper memory)

 [ Minimal BASH-like line editing is supported.  For the first word, TAB
   lists possible command completions.  Anywhere else TAB lists the possible
   completions of a device/filename. ]

grub> root (fd0,)

Error 12: Invalid device requested

grub> setup  --stage2=/floppy/boot/grub/stage2 --prefix=/boot/grub (fd0)

Error 12: Invalid device requested

grub> quit
address@hidden://usr/sbin> 
[...]

I have an uptodate woody system, running on 2.2.17 Intel architecture.

The following patch makes two things:
a) insert set -e because if something goes wrong, the following grub
   command can be very dangerous.
b) correct 'sed' statements when stripping device parts

--- grub-install.orig   Wed Dec 13 13:25:21 2000
+++ grub-install        Wed Dec 13 14:03:35 2000
@@ -1,5 +1,5 @@
 #! /bin/sh
-
+set -e
 # Install GRUB on your drive.
 #   Copyright (C) 1999, 2000 Free Software Foundation, Inc.
 #
@@ -76,10 +76,11 @@
     # Break the device name into the disk part and the partition part.
     case "$host_os" in
     linux*)
-       tmp_disk=`echo "$1" | sed -e 's%\([sh]d[a-z]\)[0-9]*$%\1%'
-                                 -e 's%/part[0-9]*$%/disc%'`
-       tmp_part=`echo "$1" | sed -e 's%.*/[sh]d[a-z]\([0-9]*\)$%\1%'
-                                 -e 's%.*/\(disc\|part\([0-9]*\)\)$%\2%'`
+       tmp_disk=`echo "$1" | sed -e 's%\([sh]d[a-z]\)[0-9]*$%\1%' \
+                           | sed -e 's%/part[0-9]*$%/disc%'`
+       tmp_part=`echo "$1" | sed -e 's%.*/[sh]d[a-z]\([0-9]*\)$%\1%' \
+                           | sed -e 's%.*/\(disc\|part\([0-9]*\)\)$%\2%' \
+                           | sed -e "s%$tmp_disk%%"`
        ;;
     gnu*)
        tmp_disk=`echo "$1" | sed 's%\([sh]d[0-9]*\).*%\1%'`



Greetings, Bastian


---------------------------------------
Received: (at 75333-close) by bugs.debian.org; 29 May 2001 19:17:00 +0000
>From address@hidden Tue May 29 14:17:00 2001
Return-path: <address@hidden>
Received: from auric.debian.org [206.246.226.45] (mail)
        by master.debian.org with esmtp (Exim 3.12 1 (Debian))
        id 154ozD-0000Yi-00; Tue, 29 May 2001 14:16:59 -0500
Received: from troup by auric.debian.org with local (Exim 3.12 1 (Debian))
        id 154ofN-0003rQ-00; Tue, 29 May 2001 14:56:29 -0400
From: Jason Thomas <address@hidden>
To: address@hidden
X-Katie: $Revision: 1.42 $
Subject: Bug#75333: fixed in grub 0.5.96.1.cvs20010528-1
Message-Id: <address@hidden>
Sender: James Troup <address@hidden>
Date: Tue, 29 May 2001 14:56:29 -0400
Delivered-To: address@hidden

We believe that the bug you reported is fixed in the latest version of
grub, which has been installed in the Debian FTP archive:

grub-doc_0.5.96.1.cvs20010528-1_all.deb
  to pool/main/g/grub/grub-doc_0.5.96.1.cvs20010528-1_all.deb
grub_0.5.96.1.cvs20010528.orig.tar.gz
  to pool/main/g/grub/grub_0.5.96.1.cvs20010528.orig.tar.gz
grub_0.5.96.1.cvs20010528-1.dsc
  to pool/main/g/grub/grub_0.5.96.1.cvs20010528-1.dsc
grub_0.5.96.1.cvs20010528-1.diff.gz
  to pool/main/g/grub/grub_0.5.96.1.cvs20010528-1.diff.gz
grub_0.5.96.1.cvs20010528-1_i386.deb
  to pool/main/g/grub/grub_0.5.96.1.cvs20010528-1_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to address@hidden,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jason Thomas <address@hidden> (supplier of updated grub package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing address@hidden)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon, 28 May 2001 17:04:44 +1000
Source: grub
Binary: grub-doc grub
Architecture: source all i386
Version: 0.5.96.1.cvs20010528-1
Distribution: unstable
Urgency: low
Maintainer: Jason Thomas <address@hidden>
Changed-By: Jason Thomas <address@hidden>
Description: 
 grub       - GRand Unified Bootloader
 grub-doc   - Documentation for GRand Unified Bootloader
Closes: 35849 72311 72346 74429 75333 78471 80241 80276 80394 80422 92269 95594 
98750
Changes: 
 grub (0.5.96.1.cvs20010528-1) unstable; urgency=low
 .
   * New Maintainer (closes: #80394)
   * updated standards version.
   * changed to use debhelper.
   * move html doco into a seperate grub-doc package.
   * Took a cvs snapshot to help close a bunch of bugs.
   * cvs snapshot fixes grub-install (closes: #75333, #80276, #98750)
   * cvs snapshot should fix "Error 22: No such partition" (closes: #80241)
   * cvs snapshot should fix symlink problem (closes: #95594)
   * grub supports /boot as seperate partition (closes: #78471)
   * grub supports devfs already (closes: #72346)
   * Changed dir of architecture specific files to /usr/lib (closes: #72311)
   * texi2html problem fixed in previous NMU (closes: #80422)
   * kernel-package supports kernel images in /boot (closes: #74429)
   * the current method for a temporary modification of a menu option is
     to press 'e' for edit. I think this is satisfactory. (closes: #35849)
   * update-grub is in the progeny package of grub
     please contact them (closes: #92269)
Files: 
 ab653bc278c289e6e9f7975a2ed14324 666 base optional 
grub_0.5.96.1.cvs20010528-1.dsc
 93c6263f3e2de8020eae9854c601d1b8 667241 base optional 
grub_0.5.96.1.cvs20010528.orig.tar.gz
 a3d542a495e4bd16318d4e8e8e564709 69210 base optional 
grub_0.5.96.1.cvs20010528-1.diff.gz
 17c00b0bb1b5217c8738e6a59f679ad0 160350 base optional 
grub-doc_0.5.96.1.cvs20010528-1_all.deb
 8701ba7df4725dd6ac20d68c6173d38f 276234 base optional 
grub_0.5.96.1.cvs20010528-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.5 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE7EgY67cYwRJJSiL4RAr4wAJ0TLwwdrW6ospqnkJe74qLXZAlnyQCfUG4S
cRA6g6EAJtrg3EzEw8RgemM=
=JRMK
-----END PGP SIGNATURE-----