Re: [PATCH] Various menu related enhancements

[Adam Lackorzynski]

Hi,

On Mon Oct 21, 2002 at 19:24:26 +0900, Yoshinori K. Okuji wrote:
> At Mon, 14 Oct 2002 16:48:35 +0200,
> Adam Lackorzynski wrote:
> >  - 01_menu_vi_up_down.diff:
> >    * Add vi like up and down in menu (j and k keys).
> 
> Why doesn't support for cursor keys satisfy you? As GRUB follows
> GNU-style key bindings (i.e. Emacs and BASH), I don't think vi-like
> key bindings would fit, anyway.

I'm a vi(m) user most of the day and I often catch myself pressing these
keys, so it's just convenient for me (and probably other vi users).

> >  - 02_menu_reload.diff:
> >    * Key 'r' for reload of the current menu. Useful when the config
> >      comes via TFTP and is modified when the menu is already loaded.
> 
> Isn't this enough:
> 
> title Reload the menu
> configfile (nd0)/tftpboot/menu.lst

This is the way we all did it. I was just tired of adding such an entry
for every menu I have and to scroll there to update the menu (even more
annoying if there's no page up and down). Just pressing 'r' is so much
easier.

> >  - 03_menu_entry_display.diff:
> >    * Display the number of the current entry in the top right corner of
> >      the menu frame. It's useful to know which number to put in the
> >      "Default" directive when the config menu is a longer than usual.
> 
> Because you need to use an OS to edit the menu file, I don't think
> it would be so useful that GRUB itself shows such a number. On a
> UNIX-like OS, you could do:

Ok, that's true. It's just for simplicity. Seeing the number directly is
easier than to have it looked up first before editing the menu.lst file.
It's just laziness. :)

> >  - 06_menu_history.diff:
> >    * Add a history for the menu. Use key left to get to the previous
> >      menu.
> 
> I wonder if this is so useful generally. This consumes precious memory
> statically, and few people use nested menus. I think it would be
> better to omit this feature, until we can use memory dynamically.

Ok, I have some nested menus and find the history function very useful.
It's probably true that I'm in a minority here. ;)


I'll keep the non-integrated patches separately and I'll try to update
them regularly in case others find them useful.


Thanks,
Adam
-- 
Adam                 address@hidden
  Lackorzynski         http://os.inf.tu-dresden.de/~adam/