[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Grub Failure when HDD descriptor changes

From: Molle Bestefich
Subject: Re: Grub Failure when HDD descriptor changes
Date: Tue, 22 Mar 2005 22:19:52 +0100

Yoshinori K. Okuji wrote:
>> Incidentally, could you perhaps offer your comments on the attached patch?
> ChangeLog, please.

Any preferred length, formatting, ?..

"Shuffle BLKGETSIZE and HD_GETGEO so that a correct sector count can
be retrieved for device-mapper devices in the stage2 simulator."

A more verbose changelog could include this too:
"GRUB would previously die with "24 : Attempt to access block outside
partition" in the partition walking code when retrieving an extended
partition table outside of the default CHS bounds (2.441 MB)."

I'd appreciate it if the code could get some tests and reviews, as I'm
nowhere near home in the world of GRUB.

Specifically, I'd like the person who originally wrote device.c to
comment on the ordering of HDIO_GETGEO and BLKGETSIZE.  I'm guessing
it's just random, but I could be mistaken!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]