[bug #52311] completion.c: GRUB_PARSER_STATE_QUOTE is checked twice

[AppChecker]

URL:
  <http://savannah.gnu.org/bugs/?52311>

                 Summary: completion.c: GRUB_PARSER_STATE_QUOTE is checked
twice
                 Project: GNU GRUB
            Submitted by: appchecker
            Submitted on: Mon 30 Oct 2017 05:47:50 PM UTC
                Category: Compilation
                Severity: Major
                Priority: 5 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 
                 Release: Git master
         Reproducibility: None
         Planned Release: None

    _______________________________________________________

Details:

Hi,
in this code fragment
(http://git.savannah.gnu.org/cgit/grub.git/tree/grub-core/normal/completion.c?id=446794de8da4329ea532cbee4ca877bcafd0e534#n495):

if (*escstr == ' ' && cmdline_state != GRUB_PARSER_STATE_QUOTE
              && cmdline_state != GRUB_PARSER_STATE_QUOTE)

cmdline_state != GRUB_PARSER_STATE_QUOTE is repeated twice

Probably, is should be:
if (*escstr == ' ' && cmdline_state != GRUB_PARSER_STATE_QUOTE
              && cmdline_state != GRUB_PARSER_STATE_DQUOTE)

This possible defect found by AppChecker
(https://npo-echelon.ru/en/solutions/appchecker.php)








    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52311>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/