[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #57889] grub-install no longer installs locales

From: Martin Whitaker
Subject: [bug #57889] grub-install no longer installs locales
Date: Mon, 24 Feb 2020 18:00:19 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0


                 Summary: grub-install no longer installs locales
                 Project: GNU GRUB
            Submitted by: martinwhitaker
            Submitted on: Mon 24 Feb 2020 11:00:17 PM UTC
                Category: Installation
                Severity: Major
                Priority: 5 - Normal
              Item Group: Software Error
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: Git master
         Discussion Lock: Any
         Reproducibility: Every Time
         Planned Release: None



grub-install should install the specified (or, if not specified, all
available) locale files in the target directory. As of 2.04, it no longer does
this. This regression was introduced by

> commit 3d8439da8c9a4acf9bc1c41b364ec6e1680ef052
> Author: Olaf Hering <address@hidden>
> Date:   Fri Apr 13 23:36:49 2018 +0200
>     grub-install: Locale depends on nls
>     With --disable-nls no locales exist.

This commit surrounds the code that copies the locale files with the

> #if !(defined (GRUB_UTIL) && defined(ENABLE_NLS) && ENABLE_NLS)

This condition is inverted, and should be

> #if (defined (GRUB_UTIL) && defined(ENABLE_NLS) && ENABLE_NLS)

The attached patch fixes the problem.


File Attachments:

Date: Mon 24 Feb 2020 11:00:17 PM UTC  Name:
0001-grub-install-fix-inverted-test-for-NLS-enabled-when-.patch  Size: 1KiB  
By: martinwhitaker



Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]