bug-gsrc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

package-list breaks when PAGER is not "less"


From: Fabrice BAUZAC
Subject: package-list breaks when PAGER is not "less"
Date: Wed, 30 Dec 2020 21:42:17 +0100

Hello,

As I use Emacs shell buffers as my mail terminals, which handles paging
by themselves, I have the habit of setting environment variable
PAGER=cat to make sure no pager interferes.

It sure works in most cases, but in the case of gsrc's
"make package-list" it doesn't, because:

PAGER_OPTS = -r
COMMAND... | $(PAGER) $(PAGER_OPTS)
and "cat -r" does not work.

I suggest the following change if you agree?  It still allows users to
choose the pager (and options) of their liking by setting the PAGER
environment variable alone.

--- old/GNUmakefile.am  2020-01-21 05:31:16 +0000
+++ new/GNUmakefile.am  2020-12-30 20:32:05 +0000
@@ -51,8 +51,7 @@
 
 #PACKAGES ?= $(BIO_PACKAGES) $(LIBS_PACKAGES) $(TOOLS_PACKAGES) 
$(DEV_PACKAGES) $(GNU_PACKAGES) $(GNOME_PACKAGES) $(GNUSTEP_PACKAGES) 
$(OTHER_PACKAGES)  
 PACKAGES ?= $(BIO_PACKAGES)  $(GNU_PACKAGES) $(GNUALPHA_PACKAGES) 
$(GNUSTEP_PACKAGES)   $(GNOME_PACKAGES) $(FREEDESKTOP_PACKAGES) 
$(GSTREAMER_PACKAGES) $(OTHER_PACKAGES)  $(XORG_PACKAGES)
-PAGER ?= less
-PAGER_OPTS = "-r"
+PAGER ?= less -r
 
 FROM ?= yesterday
 TO ?= today
@@ -85,7 +84,7 @@
 package-list:
        @for i in $(PACKAGES)  ; do \
                if [ -d $$i ] ; then $(MAKE) -sC $$i pkg-info-curt || eval 
$$failcom;  fi \
-       done | $(PAGER) $(PAGER_OPTS)
+       done | $(PAGER)
 
 clean .DEFAULT:
        @fail= failcom='exit 1'; \

Thanks!

Best regards

-- 
Fabrice Bauzac-Stehly
PGP 01EEACF8244E9C14B551C5256ADA5F189BD322B6
old PGP 015AE9B25DCB0511D200A75DE5674DEA514C891D



reply via email to

[Prev in Thread] Current Thread [Next in Thread]