Re: [bug-gtypist] GTypist beginner mode

[Felix Natter]

Tim Marston <address@hidden> writes:

> Hi Felix,
>
> On 02/02/12 18:41, Felix Natter wrote:
>> Thanks. It's not perfect, but the user should notice that the message
>> screen is scrollable.
>
> Definitely. It looks good.

I have looked at the speedbox code, it looks really good.

> I've just checked in some changes to the infoview text and I wanted to
> explain why I'd made them...

Thanks.

> - I've removed references to the version number because it'll be a
> nightmare to keep it up-to-date in all the translations!

Yes, maybe we should define a placeholder for this, like
###GTYPIST_VERSION###?

> - I've removed the list of other lessons, for the same reason, and also
> because the list is available in the menu (I've actually changed the
> text to point the user towards the menu).

Ok, in some version (2.11?)  we should add a command to switch the current
lesson at runtime.

> - I have removed the part about resizing the terminal window. I think
> it's too general and makes too many assumptions. For example, my Windows
> terminal doesn't have a "Properties" menu option (it's Cygwin's mintty).
> Users of UNIX operating systems may not even be running X11 (or
> Wayland). Personally, I feel that explaining how to resize the terminal
> emulator is beyond the scope of our introduction text. What do you think?

Hmm, it's a very important thing: you don't want to learn typing on
a (by default!) tiny terminal window! How about saying:
"If you want to know how to resize the gtypist window, please look at 
the manual in section XXX."?

> - I've also neatened-up a couple of bits, added the documentation URL,
> added a note for translators about message width (this goes through to
> the .po files).

Very good.

> I also made some changes to the infoview.c...
>
> - changed detection of number of lines to ignore a final empty line
> (also had to change how msgLines is populated, because strsep() returns
> one-too-many lines after the previous change) and corrected the
> calculation of height.

Thanks for the improvement / clean up.

> - vertically centred the dialog box (do you think this looks better in a
> large terminal window?)

Yes. 

> - moved the "Press ENTER or [...]" message to the bottom of the screen,
> because that's where all those kinds of messages appear in gtypist!  :o)

Good. 

> A couple of other ideas I had...
>
> - I wondered if you should use the banner colour to draw the dialog box
> frame with? It might make it stand out a little more.

Yes, we should try that.

> - It might be nice to get the normal gtypist banner overhead whilst the
> infoview text is on the screen.

Also agreed. I've put all these items in the TODO file on master.

Best Regards,
-- 
Felix Natter