Re: [bug-gtypist] gtypist fails to build with ncurses[tinfo]

[Felix Natter]

David Abbott <address@hidden> writes:

> Hi,

hi Tim,

> I am the proxy-maintainer for gtypist for Gentoo. Looks like gtypist
> is not using pkg-config to detect ncurses. Here is the bug report,
> thanks for your help.
>
> https://bugs.gentoo.org/show_bug.cgi?id=483778
>
> And here is the tracker with some more info;
> https://bugs.gentoo.org/show_bug.cgi?id=457530

the patch seems to be simple:

---------------------------------
diff --git a/configure.ac b/configure.ac
index c776d3b..8f538fc 100644
--- a/configure.ac
+++ b/configure.ac
@@ -46,16 +46,18 @@ AC_CHECK_FUNCS([__argz_count __argz_next __argz_stringify 
dcgettext getcwd getwd
 
 # check for libncursesw
 
-AC_CHECK_HEADER(ncursesw/ncurses.h, HAVE_NCURSESW_H=1)
-AC_CHECK_LIB(ncursesw, add_wch, HAVE_LIBNCURSESW=1)
-if test -n "$HAVE_NCURSESW_H" -a -n "$HAVE_LIBNCURSESW";  then
-   LIBS="-lncursesw $LIBS"
-else
-   echo -e "Error:  both library and header files for the ncursesw library\n"\
-       "are required to build this package.  See INSTALL file for"\
-       "further information. On Debian/Ubuntu you need to install 
libncursesw5-dev."
-   exit 1;
-fi
+dnl AC_CHECK_HEADER(ncursesw/ncurses.h, HAVE_NCURSESW_H=1)
+dnl AC_CHECK_LIB(ncursesw, add_wch, HAVE_LIBNCURSESW=1)
+dnl if test -n "$HAVE_NCURSESW_H" -a -n "$HAVE_LIBNCURSESW";  then
+dnl    LIBS="-lncursesw $LIBS"
+dnl else
+dnl    echo -e "Error:  both library and header files for the ncursesw 
library\n"\
+dnl            "are required to build this package.  See INSTALL file for"\
+dnl    "further information. On Debian/Ubuntu you need to install 
libncursesw5-dev."
+dnl    exit 1;
+dnl fi
+
+PKG_CHECK_MODULES([NCURSESW], [ncursesw])
 
 # Internationalization macros
 
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -12,7 +12,7 @@ gtypist_SOURCES = gtypist.c cursmenu.c script.c error.c 
getopt.c getopt1.c            \
        infoview.c speedbox.c banner.c cmdline.c cursmenu.h error.h getopt.h    
        \
        gettext.h gtypist.h script.h utf8.c utf8.h infoview.h speedbox.h 
banner.h       \
        cmdline.h cmdline.ggo
-gtypist_LDADD = @LIBINTL@
+gtypist_LDADD = @LIBINTL@ @NCURSESW_LIBS@
 
 AM_CPPFLAGS = -I../intl \
   -DDATADIR=\"$(pkgdatadir)\" \
---------------------------------

I have a few questions concerning the fix:

- where should I add @address@hidden

- src/Makefile.am contains the following header:
## Process this file with automake to produce Makefile.in

#
#       NOTE:  this file will probably be changed by gettextize, so don't
#       commit changed version into CVS.
#

=> is this still applicable?

Kind Regards,
-- 
Felix Natter